From 632f4408df05501b02d3e2f951bfdd335ea515ba Mon Sep 17 00:00:00 2001 From: Chris Allen Date: Tue, 27 Feb 2018 18:32:10 -0600 Subject: [PATCH] Deprecate rand, EOrderRandom --- src/Database/Esqueleto/Internal/Language.hs | 2 ++ src/Database/Esqueleto/Internal/Sql.hs | 1 + 2 files changed, 3 insertions(+) diff --git a/src/Database/Esqueleto/Internal/Language.hs b/src/Database/Esqueleto/Internal/Language.hs index adb53ef..ef47ee1 100644 --- a/src/Database/Esqueleto/Internal/Language.hs +++ b/src/Database/Esqueleto/Internal/Language.hs @@ -591,6 +591,8 @@ class (Functor query, Applicative query, Monad query) => {-# DEPRECATED random_ "Since 2.6.0: `random_` is not uniform across all databases! Please use a specific one such as 'Database.Esqueleto.PostgreSQL.random_', 'Database.Esqueleto.MySQL.random_', or 'Database.Esqueleto.SQLite.random_'" #-} +{-# DEPRECATED rand "Since 2.6.0: `rand` ordering function is not uniform across all databases! To avoid accidental partiality it will be removed in the next major version." #-} + -- Fixity declarations infixl 9 ^. infixl 7 *., /. diff --git a/src/Database/Esqueleto/Internal/Sql.hs b/src/Database/Esqueleto/Internal/Sql.hs index 847e6af..bd8a5b9 100644 --- a/src/Database/Esqueleto/Internal/Sql.hs +++ b/src/Database/Esqueleto/Internal/Sql.hs @@ -1159,6 +1159,7 @@ makeOrderBy info os = first ("\nORDER BY " <>) . uncommas' $ concatMap mk os orderByType ASC = " ASC" orderByType DESC = " DESC" +{-# DEPRECATED EOrderRandom "Since 2.6.0: `rand` ordering function is not uniform across all databases! To avoid accidental partiality it will be removed in the next major version." #-} makeLimit :: IdentInfo -> LimitClause -> [OrderByClause] -> (TLB.Builder, [PersistValue]) makeLimit (conn, _) (Limit ml mo) orderByClauses =