From 72301adfe3cddb02b6da36d3b3bb990aac2dec28 Mon Sep 17 00:00:00 2001
From: Sarah Vaupel <sarah.vaupel@uniworx.de>
Date: Wed, 23 Oct 2024 01:50:40 +0200
Subject: [PATCH] build(Makefile): improve container names for distinction
 between backend, hoogle and uniworxdb containers

---
 Makefile | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/Makefile b/Makefile
index 8a30163d5..a8c53d848 100644
--- a/Makefile
+++ b/Makefile
@@ -7,6 +7,8 @@ export CONTAINER_COMMAND ?= podman
 export CONTAINER_BGRUN ?= $(CONTAINER_COMMAND) run -dit --network=host
 export CONTAINER_FGRUN ?= $(CONTAINER_COMMAND) run -it --network=host
 
+export CONTAINER_NAME = $(FRADRIVE_SERVICE)
+
 export IN_CONTAINER ?= false
 export IN_CI ?= false
 
@@ -243,9 +245,15 @@ db: --image-build --containerized---db;
 --containerized-%-backend: FRADRIVE_SERVICE=backend
 --containerized-%-backend: --image-build
 	$(MAKE) -- --image-run-$*-backend 
+--containerized-%-hoogle: CONTAINER_NAME=hoogle
 --containerized-%-hoogle: --containerized-%-hoogle-backend;
+--containerized---db: CONTAINER_NAME=uniworxdb
 --containerized---db: --containerized-db-backend;
 
+--containerized-%-database: FRADRIVE_SERVICE=database
+--containerized-%-database: --image-build
+	$(MAKE) -- --image-run-$*-database
+
 # --containerized-%-minio: FRADRIVE_SERVICE=minio
 # --containerized-%-minio: --image-build
 # 	$(MAKE) -- --image-run-$*-minio
@@ -265,10 +273,6 @@ db: --image-build --containerized---db;
 	CONTAINER_ID=`$(CONTAINER_BGRUN) --name fradrive.memcached.$$(date +'%Y-%m-%dT%H-%M-%S') $(MEMCACHED_IMAGE) --port=$${MEMCACHED_PORT}` ; \
 	printf "CONTAINER_ID=$${CONTAINER_ID}\nMEMCACHED_PORT=$${MEMCACHED_PORT}" >> $(CONTAINER_FILE)
 
---containerized-%-database: FRADRIVE_SERVICE=database
---containerized-%-database: --image-build
-	$(MAKE) -- --image-run-$*-database
-
 .PHONY: image-rebuild
 # HELP(image-rebuild-{backend,frontend,database,memcached,minio}): force-rebuild the stated docker image
 image-rebuild-%:
@@ -285,16 +289,17 @@ image-rebuild-%:
 	  $(CONTAINER_COMMAND) build $(NO_CACHE) -v $(PWD):$${MOUNT_DIR} --env IN_CONTAINER=true --build-arg MOUNT_DIR=$${MOUNT_DIR} --build-arg PROJECT_DIR=$${PROJECT_DIR} --tag fradrive/$(FRADRIVE_SERVICE) --file $(PWD)/.Dockerfile ; \
 	fi
 
+--image-run-%: CONTAINER_NAME = $(FRADRIVE_SERVICE)
 --image-run-%: docker/$(FRADRIVE_SERVICE)/Dockerfile
 	MOUNT_DIR=/mnt/fradrive; \
 	if [ "$(IN_CONTAINER)" == "true" ] ; then \
 	  $(MAKE) -- $* ; \
 	else \
 	  if [ -z "$(CONTAINER_FILE)" ] ; then \
-	    $(CONTAINER_FGRUN) -v $(PWD):$${MOUNT_DIR} --env IN_CONTAINER=true --env FRADRIVE_MAKE_TARGET=$* --env CONTAINER_FILE=$(CONTAINER_FILE) --env CONTAINER_FILE_CONTENT=$(CONTAINER_FILE_CONTENT) --env WATCH=$(WATCH) --name fradrive.$(FRADRIVE_SERVICE).$$(date +'%Y-%m-%dT%H-%M-%S') localhost/fradrive/$(FRADRIVE_SERVICE) ; \
+	    $(CONTAINER_FGRUN) -v $(PWD):$${MOUNT_DIR} --env IN_CONTAINER=true --env FRADRIVE_MAKE_TARGET=$* --env CONTAINER_FILE=$(CONTAINER_FILE) --env CONTAINER_FILE_CONTENT=$(CONTAINER_FILE_CONTENT) --env WATCH=$(WATCH) --name fradrive.$(CONTAINER_NAME).$$(date +'%Y-%m-%dT%H-%M-%S') localhost/fradrive/$(FRADRIVE_SERVICE) ; \
 	  else \
 	  	./utils/watchcontainerrun.sh "$(CONTAINER_COMMAND)" "$(CONTAINER_FILE)" & \
-	    CONTAINER_ID=`$(CONTAINER_BGRUN) -v $(PWD):$${MOUNT_DIR} --env IN_CONTAINER=true --env FRADRIVE_MAKE_TARGET=$* --env CONTAINER_FILE=$(CONTAINER_FILE) --env CONTAINER_FILE_CONTENT=$(CONTAINER_FILE_CONTENT) --env WATCH=$(WATCH) --name fradrive.$(FRADRIVE_SERVICE).$$(date +'%Y-%m-%dT%H-%M-%S') localhost/fradrive/$(FRADRIVE_SERVICE)` ; \
+	    CONTAINER_ID=`$(CONTAINER_BGRUN) -v $(PWD):$${MOUNT_DIR} --env IN_CONTAINER=true --env FRADRIVE_MAKE_TARGET=$* --env CONTAINER_FILE=$(CONTAINER_FILE) --env CONTAINER_FILE_CONTENT=$(CONTAINER_FILE_CONTENT) --env WATCH=$(WATCH) --name fradrive.$(CONTAINER_NAME).$$(date +'%Y-%m-%dT%H-%M-%S') localhost/fradrive/$(FRADRIVE_SERVICE)` ; \
 	    echo "CONTAINER_ID=$${CONTAINER_ID}" >> "$(CONTAINER_FILE)"; \
 	  fi \
 	fi